[PATCH] D31787: [TLI] Add declarations for various math header file routines from math-finite.h that create '__<func>_finite as functions

Ahmed Bougacha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 14:35:38 PDT 2017


ab added a comment.

This looks fine; the TLI unittest is the best place for testing this. (for instance, no-proto.ll wouldn't help, because the pass doesn't know about these libfuncs and can't modify them anyway, regardless of the prototype)

Beyond that, I'm curious: should these be added as names only, and treated as "aliases" of the non-finite functions (only when -ffinite-math-only) ?    Or, put another way: is it ever desirable to distinguish between them?


https://reviews.llvm.org/D31787





More information about the llvm-commits mailing list