[PATCH] D32722: Verify that all references point to actual DIEs in "llvm-dwarfdump --verify"

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 13:42:39 PDT 2017


clayborg added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:309
+    // lies between to valid DIEs.
+    std::map<uint64_t, std::set<uint32_t>> ReferenceToDIEOffsets;
+
----------------
aprantl wrote:
> Do we need a sorted container here or would an llvm::DenseMap be sufficient (and faster)?
We can change this if needed. std::unordered_set would work as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D32722





More information about the llvm-commits mailing list