[PATCH] D32737: [Constants][SVE] Represent the runtime length of a scalable vector

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: include/llvm-c/Core.h:1188
       macro(UndefValue)                     \
+      macro(VScaleValue)                    \
     macro(Instruction)                      \
----------------
Not being in the same order as above may confuse people looking for it?


================
Comment at: include/llvm/IR/Value.def:92
 HANDLE_CONSTANT_MARKER(ConstantFirstVal, Function)
-HANDLE_CONSTANT_MARKER(ConstantLastVal, ConstantTokenNone)
+HANDLE_CONSTANT_MARKER(ConstantLastVal, VScaleValue)
 HANDLE_CONSTANT_MARKER(ConstantDataFirstVal, UndefValue)
----------------
I don't get this change...


================
Comment at: lib/IR/Constants.cpp:812
+  // Free the constant and any dangling references to it.
+  getContext().pImpl->VSVConstants.erase(getType());
+}
----------------
So, in theory, you can have vscale constans of different integer types, and this would only clear the ones that are the same as this one? 

This sounds confusing.


https://reviews.llvm.org/D32737