[PATCH] D32688: [Coverage] Comdat section name should be same as the variable name in COFF format

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

I suspect that the appropriate fix is to give the __profd variables internal linkage, not to change the comdat name. The linker will still discard duplicate profc and profd sections with this change.

Actually, I'm surprised that the profiling data isn't comdat associated with the function itself. Is it possible for instrprofiling to be different across different TUs, or to link PGO instrumented code with non-PGO instrumented code? If that's the case, we probably want to make all profiling metadata associated with the function itself.


https://reviews.llvm.org/D32688