[PATCH] D32354: [ELF] - Set DF_STATIC_TLS flag for i386 target.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 06:57:23 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D32354#738340, @ruiu wrote:

> The other way of doing this is to add code to relocateOne, to record whether we handle TLS IE/LD relocations or not. This is probably the least expensive way as it doesn't involve any virtual function calls.


relocateOne is called really late, during writeTo. That is much later than finalizeContents() where we finish updating the DT_* entries. It does not look clean to do it there, probably ?


https://reviews.llvm.org/D32354





More information about the llvm-commits mailing list