[PATCH] D32289: [ELF] - Linkerscript: support combination of linkerscript and --compress-debug-sections.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Tue May 2 06:52:00 PDT 2017
> +# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux \
> +# RUN: %S/Inputs/compress-debug-sections.s -o %t1.o
> +# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t2.o
> +# RUN: echo "SECTIONS { }" > %t.script
Please also test the non orphan case.
> Index: ELF/OutputSections.cpp
> ===================================================================
> --- ELF/OutputSections.cpp
> +++ ELF/OutputSections.cpp
> @@ -93,6 +93,11 @@
> !Name.startswith(".debug_"))
> return;
>
> + // We call maybeCompress() early and for linkerscript case need to assign offsets,
> + // because that was not done yet. That finalizes mergeable synthetic sections and
> + // also finds output section total size for use in compressing code below.
> + assignOffsets();
We really should not have different assignOffsets calls for the compress
case.
Cheers,
Rafael
More information about the llvm-commits
mailing list