[PATCH] D32687: [DAGCombine] (uaddo X, (addcarry Y, 0, Carry)) -> (addcarry X, Y, Carry)
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 2 05:51:08 PDT 2017
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of minors
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2095
+ auto Y = N1.getOperand(0);
+ auto One = DAG.getConstant(1, SDLoc(N), Y.getValueType());
+ if (DAG.computeOverflowKind(Y, One) == SelectionDAG::OFK_Never)
----------------
Use SDValue if possible please.
https://reviews.llvm.org/D32687
More information about the llvm-commits
mailing list