[PATCH] D32701: [LLVM][inline-asm][Altmacor] Altmacro string delimiter '<..>'

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: lib/MC/MCParser/AsmParser.cpp:1201
+/// character.
+bool AsmParser::isAltmacroString(SMLoc &StrLoc, SMLoc &EndLoc) {
+  assert((StrLoc.getPointer() != NULL) &&
----------------
I'd add single quotes at the same time.

This seems like a simple addition, as you can pass the expected "ending char" as an argument, in addition to `\r\n\0`.


================
Comment at: lib/MC/MCParser/AsmParser.cpp:2501
     }
+    else if (Lexer.IsaAltMacroMode() && Lexer.is(AsmToken::Less) &&
+             isAltmacroString(StrLoc, EndLoc)) {
----------------
Format else in the same line, like `} else {`


https://reviews.llvm.org/D32701