[PATCH] D32731: ELF: Set symbol binding to STB_GLOBAL when undefining symbols during LTO.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 22:16:14 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/LTO.cpp:108
                          STV_DEFAULT, S->body()->Type, nullptr);
+  S->Binding = STB_GLOBAL;
 }
----------------
Please add a comment to describe why you are doing this. Without comment it is hard to understand why because the linker works fine without this piece of code.


https://reviews.llvm.org/D32731





More information about the llvm-commits mailing list