[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lib/Object/COFFImportFile.cpp:116
+  }
+  return (Twine(S.substr(0, Pos)) + To + S.substr(Pos + From.size())).getSingleStringRef();
+}
----------------
This is returning a newly created string, so I don't think you can return `Expected<StringRef>` here.


Repository:
  rL LLVM

https://reviews.llvm.org/D32689