[PATCH] D32681: [builtins] Enabled emulated TLS on WOA.

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 18:20:19 PDT 2017


martell added a comment.

In https://reviews.llvm.org/D32681#742912, @compnerd wrote:

> I have a local patch (well, it's either on reviews.llvm.org or on the mailing list as well) that emulates the case insensitivity, but that is expensive, and I'd rather keep the hit to the actual file when possible.  How about adding a guard around the incorrect case (yes, Microsoft doesn't get the case right, but the SDK provides the file with the capital name, so that should be the official version IMO).


Adding a Guard for having an upper and lower case windows.h include would be very ugly and is not done anywhere else in the codebase.
Here is a reference another location where `windows.h` is included in LLVM.
https://github.com/llvm-mirror/llvm/blob/master/lib/Support/Windows/WindowsSupport.h#L47

Building for mingw i686 and x86_64 from linux is broken for me atm without this patch.
I just need the go ahead to push to fix that :)


Repository:
  rL LLVM

https://reviews.llvm.org/D32681





More information about the llvm-commits mailing list