[llvm] r301890 - [AArch64] armv8-A doesn't have LSE.
Ahmed Bougacha via llvm-commits
llvm-commits at lists.llvm.org
Mon May 1 17:45:02 PDT 2017
Author: ab
Date: Mon May 1 19:45:01 2017
New Revision: 301890
URL: http://llvm.org/viewvc/llvm-project?rev=301890&view=rev
Log:
[AArch64] armv8-A doesn't have LSE.
r288279 mistakenly added it to all arches, but it's only available
from v8.1 onwards.
The testcase is awkward, because (I suspect) of PR32873.
Spotted by inspection.
Modified:
llvm/trunk/include/llvm/Support/AArch64TargetParser.def
llvm/trunk/test/MC/AArch64/directive-arch-negative.s
Modified: llvm/trunk/include/llvm/Support/AArch64TargetParser.def
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/AArch64TargetParser.def?rev=301890&r1=301889&r2=301890&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/AArch64TargetParser.def (original)
+++ llvm/trunk/include/llvm/Support/AArch64TargetParser.def Mon May 1 19:45:01 2017
@@ -21,7 +21,7 @@ AARCH64_ARCH("invalid", AK_INVALID, null
AARCH64_ARCH("armv8-a", AK_ARMV8A, "8-A", "v8", ARMBuildAttrs::CPUArch::v8_A,
FK_CRYPTO_NEON_FP_ARMV8,
(AArch64::AEK_CRC | AArch64::AEK_CRYPTO | AArch64::AEK_FP |
- AArch64::AEK_SIMD | AArch64::AEK_LSE))
+ AArch64::AEK_SIMD))
AARCH64_ARCH("armv8.1-a", AK_ARMV8_1A, "8.1-A", "v8.1a",
ARMBuildAttrs::CPUArch::v8_A, FK_CRYPTO_NEON_FP_ARMV8,
(AArch64::AEK_CRC | AArch64::AEK_CRYPTO | AArch64::AEK_FP |
Modified: llvm/trunk/test/MC/AArch64/directive-arch-negative.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AArch64/directive-arch-negative.s?rev=301890&r1=301889&r2=301890&view=diff
==============================================================================
--- llvm/trunk/test/MC/AArch64/directive-arch-negative.s (original)
+++ llvm/trunk/test/MC/AArch64/directive-arch-negative.s Mon May 1 19:45:01 2017
@@ -36,6 +36,14 @@
# CHECK: error: instruction requires: ras
# CHECK: esb
+// PR32873: without extra features, '.arch' is currently ignored.
+// Add an unrelated feature to accept the directive.
+ .arch armv8+crc
+ casa w5, w7, [x19]
+
+# CHECK: error: instruction requires: lse
+# CHECK: casa w5, w7, [x19]
+
.arch armv8.1-a+nolse
casa w5, w7, [x20]
More information about the llvm-commits
mailing list