[PATCH] D32517: [ubsan] Fall back to the fast unwinder when print_stacktrace=1

[Vedant Kumar via Phabricator via llvm-commits]

vsk marked 3 inline comments as done.
vsk added a comment.

Will update shortly.



================
Comment at: lib/ubsan/ubsan_diag.cc:37
+  uptr bottom = 0;
+  const bool request_fast_unwind = false;
+  if (StackTrace::WillUseFastUnwind(request_fast_unwind))
----------------
eugenis wrote:
> vsk wrote:
> > eugenis wrote:
> > > use common_flags()->fast_unwind_on_fatal here
> > Ok. I think it would also make sense to enable the fast unwinder when fast_unwind_on_check is set, then.
> No, fast_unwind_on_check is for internal CHECK(...) failures.
I see, those failures are not surfaced through this function.


https://reviews.llvm.org/D32517