[PATCH] D32622: ARM: Compute MaxCallFrame size early

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 11:37:59 PDT 2017


MatzeB added a comment.

In https://reviews.llvm.org/D32622#742404, @MatzeB wrote:

> I had to change GlobalISel to call TLI->finalizeLowering() late in InstructionSelect instead of after IRTranslator. While most ADJCALLSTACK/CALL instructions are already visible after IRTranslator we may miss operations getting implemented by library calls later. It also seems to delay freezing the reserved registers + extra adjustments until after ISel is finished. This also matches the current SelectionDAG behavior.
>
> +Reviewers Ahmed because of the finalizeLowering/freezeReg movement.


And some more testing reveals that some GlobalISel tests use the machineverifier which in turn requires frozen reserved registers at the moment :-/. I will see how to change that...


Repository:
  rL LLVM

https://reviews.llvm.org/D32622





More information about the llvm-commits mailing list