[PATCH] D32679: [X86][AVX-512] Allow EVEX encoded instruction selection when available for mul v8i32.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

I'm sure it was a mistake, but I think it should be split from this patch and done as a pre-commit.



================
Comment at: test/CodeGen/X86/avx-isa-check.ll:683
 }
+
+define <8 x i32> @test_mul_v8i32(<8 x i32> %arg1, <8 x i32> %arg2) #0 {
----------------
What is this test really testing? Just that isel doesn't fail if you do a v8i32 mul with various isel combinations? It doesn't look like it tests which instruction is emitted. Would this test case even fail if you put it in with no other changes? If that's correct I think we should have a test that checks which instruction is emitted.


https://reviews.llvm.org/D32679