[PATCH] D32589: [sanitizer] Intercept mcheck and mprobe on Linux

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:6157
+}
+#define INIT_MCHECK_MPROBE                       \
+  COMMON_INTERCEPT_FUNCTION(mcheck);             \
----------------
eugenis wrote:
> I think INIT_MCHECK_MPROBE is simply unnecessary if we don't use REAL(mcheck). Compare with asan_malloc_linux.cc.
> 
> And we don't need to care about glibc version then.
Here, yes, but the test still need the version check for check_pedantic, right? We had this problem with getauxval, there're bots running on glibc 2.13.


Repository:
  rL LLVM

https://reviews.llvm.org/D32589