[compiler-rt] r301798 - [powerpc] deactivate flakey tests on powerpc64le

Bill Seurer via llvm-commits llvm-commits at lists.llvm.org
Mon May 1 06:56:05 PDT 2017


Author: seurer
Date: Mon May  1 08:56:04 2017
New Revision: 301798

URL: http://llvm.org/viewvc/llvm-project?rev=301798&view=rev
Log:
[powerpc] deactivate flakey tests on powerpc64le

These test cases occassionally fail when run on powerpc64le:

ignore_lib1.cc
ignore_lib5.cc
TestCases/Posix/current_allocated_bytes.cc
rtl/TsanRtlTest/Posix.ThreadLocalAccesses
TestCases/Posix/coverage-fork-direct.cc

The failures cause false problem reports to be sent to developers whose
code had nothing to do with the failures.  Reactivate them when the real
problems are fixed.

This could also be related to the same problems as with the tests
ThreadedOneSizeMallocStressTest, ThreadedMallocStressTest, ManyThreadsTest,
and several others that do not run reliably on powerpc.

Modified:
    compiler-rt/trunk/lib/tsan/tests/rtl/tsan_posix.cc
    compiler-rt/trunk/test/asan/TestCases/Posix/coverage-fork-direct.cc
    compiler-rt/trunk/test/asan/TestCases/Posix/current_allocated_bytes.cc
    compiler-rt/trunk/test/tsan/ignore_lib1.cc
    compiler-rt/trunk/test/tsan/ignore_lib5.cc

Modified: compiler-rt/trunk/lib/tsan/tests/rtl/tsan_posix.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/tests/rtl/tsan_posix.cc?rev=301798&r1=301797&r2=301798&view=diff
==============================================================================
--- compiler-rt/trunk/lib/tsan/tests/rtl/tsan_posix.cc (original)
+++ compiler-rt/trunk/lib/tsan/tests/rtl/tsan_posix.cc Mon May  1 08:56:04 2017
@@ -94,8 +94,9 @@ TEST(Posix, ThreadLocalAccesses) {
 // The test is failing with high thread count for aarch64.
 // FIXME: track down the issue and re-enable the test.
 // On Darwin, we're running unit tests without interceptors and __thread is
-// using malloc and free, which causes false data race reports.
-#if !defined(__aarch64__) && !defined(__APPLE__)
+// using malloc and free, which causes false data race reports.  On rare
+// occasions on powerpc64le this test also fails.
+#if !defined(__aarch64__) && !defined(__APPLE__) && !defined(powerpc64le)
   local_thread((void*)2);
 #endif
 }

Modified: compiler-rt/trunk/test/asan/TestCases/Posix/coverage-fork-direct.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/coverage-fork-direct.cc?rev=301798&r1=301797&r2=301798&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/Posix/coverage-fork-direct.cc (original)
+++ compiler-rt/trunk/test/asan/TestCases/Posix/coverage-fork-direct.cc Mon May  1 08:56:04 2017
@@ -7,6 +7,9 @@
 // RUN: FileCheck %s < %t.log
 //
 // XFAIL: android
+// UNSUPPORTED: powerpc64le
+// FIXME: This test occasionally fails on powerpc64 LE possibly starting with
+// r279664.  Re-enable the test once the problem(s) have been fixed.
 
 #include <stdio.h>
 #include <string.h>

Modified: compiler-rt/trunk/test/asan/TestCases/Posix/current_allocated_bytes.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/current_allocated_bytes.cc?rev=301798&r1=301797&r2=301798&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/Posix/current_allocated_bytes.cc (original)
+++ compiler-rt/trunk/test/asan/TestCases/Posix/current_allocated_bytes.cc Mon May  1 08:56:04 2017
@@ -1,6 +1,9 @@
 // RUN: %clangxx_asan -O0 %s -pthread -o %t && %run %t
 // RUN: %clangxx_asan -O2 %s -pthread -o %t && %run %t
 // REQUIRES: stable-runtime
+// UNSUPPORTED: powerpc64le
+// FIXME: This test occasionally fails on powerpc64 LE possibly starting with
+// r279664.  Re-enable the test once the problem(s) have been fixed.
 
 #include <assert.h>
 #include <pthread.h>

Modified: compiler-rt/trunk/test/tsan/ignore_lib1.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/ignore_lib1.cc?rev=301798&r1=301797&r2=301798&view=diff
==============================================================================
--- compiler-rt/trunk/test/tsan/ignore_lib1.cc (original)
+++ compiler-rt/trunk/test/tsan/ignore_lib1.cc Mon May  1 08:56:04 2017
@@ -9,6 +9,9 @@
 // in called_from_lib suppression are ignored.
 
 // REQUIRES: stable-runtime
+// UNSUPPORTED: powerpc64le
+// FIXME: This test regularly fails on powerpc64 LE possibly starting with
+// r279664.  Re-enable the test once the problem(s) have been fixed.
 
 #ifndef LIB
 

Modified: compiler-rt/trunk/test/tsan/ignore_lib5.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/ignore_lib5.cc?rev=301798&r1=301797&r2=301798&view=diff
==============================================================================
--- compiler-rt/trunk/test/tsan/ignore_lib5.cc (original)
+++ compiler-rt/trunk/test/tsan/ignore_lib5.cc Mon May  1 08:56:04 2017
@@ -6,6 +6,9 @@
 // RUN: %env_tsan_opts=suppressions='%s.supp' %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-WITHSUPP
 
 // REQUIRES: stable-runtime
+// UNSUPPORTED: powerpc64le
+// FIXME: This test occasionally fails on powerpc64 LE possibly starting with
+// r279664.  Re-enable the test once the problem(s) have been fixed.
 
 // Previously the test episodically failed with:
 //   ThreadSanitizer: called_from_lib suppression '/libignore_lib1.so$' is




More information about the llvm-commits mailing list