[PATCH] D32508: [ValueTracking] Begin adding some useful methods to the proposed KnownBits struct

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 30 08:28:24 PDT 2017


spatel added a comment.

In https://reviews.llvm.org/D32508#740518, @craig.topper wrote:

> Maybe a better name for isComplete/getValue would be isConstant and getConstant?


isConstant/getConstant are better IMO. Not sure if it would cause 'known' overload in the user code, but could remove more ambiguity with: allBitsKnown/getKnownConstant ?


https://reviews.llvm.org/D32508





More information about the llvm-commits mailing list