[PATCH] D32649: [scudo] Add Android support

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added inline comments.


================
Comment at: lib/scudo/scudo_tls.h:33
   void commitBack();
+  u64 getUnusedSince() { return atomic_load_relaxed(&UnusedSince); }
+  bool tryLock();
----------------
cryptoad wrote:
> dvyukov wrote:
> > This one liner is used only once, just inline it there. Additional levels of indirection do not help understanding code. 
> Will do.
> Additionally, UnusedSince and Mutex are only used for Android. Is worth adding an #if to not have them in the non-Android version, or is the clutter not worth it?
I am fine either way.
I've noticed the android-specific data and methods, but couldn't think of an elegant, non-overdesigned solution...


https://reviews.llvm.org/D32649