[PATCH] D32382: [tsan] Track external tags in thread traces

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

One last thing. Otherwise LGTM.



================
Comment at: lib/tsan/rtl/tsan_rtl_report.cc:662
+    if (tags[i] != kExternalTagNone) {
+      rep.SetType(ReportTypeExternalRace);
+    }
----------------
Calculate typ before creating ScopedReport and remove SetType function. It feels clumsy that we can't figure out report type when we are creating it and add setters to patch it afterwards.

  if (tags[0] != kExternalTagNone || tags[1] != kExternalTagNone)
    typ = ReportTypeExternalRace;
  ScopedReport rep(typ);

will do.


https://reviews.llvm.org/D32382