[PATCH] D32527: Generalize flag carrying SDNodes beyond binary ops. NFC.

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - thanks for fixing this!

See inline comment for one minor potential diff.



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5964
   case 0: return getNode(Opcode, DL, VT);
-  case 1: return getNode(Opcode, DL, VT, Ops[0]);
+  case 1: return getNode(Opcode, DL, VT, Ops[0], Flags);
   case 2: return getNode(Opcode, DL, VT, Ops[0], Ops[1], Flags);
----------------
Should we wait to make this change until there is a transform that uses it (and therefore a test to prove it)?


Repository:
  rL LLVM

https://reviews.llvm.org/D32527