[PATCH] D32648: Remove line and file from DINamespace

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:379
 void DwarfUnit::addSourceLine(DIE &Die, const DINamespace *NS) {
-  addSourceLine(Die, NS->getLine(), NS->getFilename(), NS->getDirectory());
+  addSourceLine(Die, 0, NS->getFilename(), NS->getDirectory());
 }
----------------
no need to pass the filename down here either? (why does DINamespace still have a 'getFilename'? (I'm assuming the reason the line isn't passed down is because DINamespace doesn't have getLine anymore?))

Yeah, I see DIScope still has getFilename - one day might be nice to refactor out some of this if not all scopes have/need this information.


================
Comment at: lib/IR/DebugInfoMetadata.cpp:513
+  DEFINE_GETIMPL_LOOKUP(DINamespace, (Scope, Name, ExportSymbols));
+  Metadata *Ops[] = {nullptr, Scope, Name};
+  DEFINE_GETIMPL_STORE(DINamespace, (ExportSymbols), Ops);
----------------
What's the first null parameter here represent/for?


https://reviews.llvm.org/D32648