[PATCH] D32575: Don't try to legalize Intermediate instructions (with generic types)

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 15:00:38 PDT 2017


aditya_nandakumar added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/Legalizer.cpp:183
+        if (isPreISelGenericOpcode(MI->getOpcode())) {
+          ++NumNewInsns;
+          WorkList.push_back(MI);
----------------
dsanders wrote:
> This line needs to happen unconditionally so that --debug-only=legalize reports the instruction.
Yes - for -debug-only printing output we would need it in the list but not process - but would disagree with Quentin's comment of not having the Instructions that are not needed in the work list.


https://reviews.llvm.org/D32575





More information about the llvm-commits mailing list