[PATCH] D32652: Gracefully handle empty .drectve sections
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 28 12:14:57 PDT 2017
smeenai added a comment.
In https://reviews.llvm.org/D32652#741088, @ruiu wrote:
> I feel like we should fix `COFFObjectFile::getSectionContents` to not fail on empty sections instead of avoid calling it on empty sections, as I naturally expect that getSectionContents returns an empty StringRef for an empty section.
That was my intuition as well, but I wasn't sure if there was a reason for the existing behavior/callers that depend on that behavior.
https://reviews.llvm.org/D32652
More information about the llvm-commits
mailing list