craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM other than the v1i8 problem in existing tablegen. Probably commit that fix as a separate pre-commit just so its not hidden in here. https://reviews.llvm.org/D32540