[PATCH] D32648: Remove line and file from DINamespace

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 28 10:50:25 PDT 2017


dblaikie added a comment.

I'm all for this, couple of questions though:

- When would the use of "distinct" on an anonymous namespace matter? Since LLVM uses cross-CU references to refer to entities in different CUs, never importing/moving entities between CUs, the anonymous namespaces shouldn't collide, should they? (anymore than named namespaces would collide when there are different entities in different CUs but both in the same named namespace - LLVM still produces two separate namespaces, one in each CU, one with each of the respective entities)?

- Which tests cover the LLVM codegen side of this change - several tests no longer look for the line/file, but do any tests ensure it is not present? (if this patch were reverted, which tests would fail (not a perfect question, since the change in the metadata format would cause parse failures - but not talking about those))


https://reviews.llvm.org/D32648





More information about the llvm-commits mailing list