[PATCH] D32615: [pdb, lld] Write CodeView line tables to PDB.

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:550-551
 enum LineFlags : uint16_t {
-  HaveColumns = 1, // CV_LINES_HAVE_COLUMNS
+  kLineFlagsNone = 0,
+  kLineFlagsHaveColumns = 1, // CV_LINES_HAVE_COLUMNS
 };
----------------
ruiu wrote:
> Is `k` prefix hangarian?
My bad, I should have called this `LF_None` and `LF_HaveColumns`.  I'll fix in a follow up


================
Comment at: llvm/include/llvm/DebugInfo/PDB/Native/ModuleDebugStream.h:64
+
+class ModuleDebugStream {};
 }
----------------
ruiu wrote:
> What is this for?
Good question, I should remove this.


https://reviews.llvm.org/D32615