[PATCH] D32648: Remove line and file from DINamespace

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added inline comments.


================
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1385-1397
   case bitc::METADATA_NAMESPACE: {
     if (Record.size() != 5)
       return error("Invalid record");
 
     IsDistinct = Record[0] & 1;
     bool ExportSymbols = Record[0] & 2;
     MetadataList.assignValue(
----------------
Is there something we should do here for upgrades for anonymous namespaces?
- Old ones won't be distinct in bitcode.
- They'll suddenly start merging.

Maybe it's not so bad if they merge, but if we do something easily (maybe triggered off of whether they have a name) we should try.


Repository:
  rL LLVM

https://reviews.llvm.org/D32648