[PATCH] D32615: [pdb, lld] Write CodeView line tables to PDB.

[Bob Haarman via Phabricator via llvm-commits]

inglorion added a comment.

It seems a little awkward to me that we're passing both a filename and an index for the same filename to createBlock. Looking through the code, I get the impression that we don't actually need the StringRef, only the index. If so, could you remove the StringRef?



================
Comment at: llvm/include/llvm/DebugInfo/CodeView/ModuleDebugFileChecksumFragment.h:1
 //===- ModuleDebugLineFragment.h --------------------------------*- C++ -*-===//
 //
----------------
Can you change this to "ModuleDebugFileChecksumFragment.h" while you're at it?


https://reviews.llvm.org/D32615