[PATCH] D32619: AMDGPU/AMDHSA: Set COMPUTE_PGM_RSRC2:LDS_SIZE to 0

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 16:52:01 PDT 2017


kzhuravl added inline comments.


================
Comment at: test/CodeGen/AMDGPU/lds-size.ll:15
 
+; HSA: granulated_lds_size = 0
+; HSA: workgroup_group_segment_byte_size = 4
----------------
arsenm wrote:
> Why do we even print this if it's always going to be 0? why is it in the kernel_code_t?
> Why do we even print this if it's always going to be 0?
I agree that we can omit printing it here. We are doing some restructuring in amd_kernel_code_t area. Can we include this topic there?

> why is it in the kernel_code_t?
granulated_lds_size is a part of COMPUTE_PGM_RSRC2 register, and we cannot omit it from there.


https://reviews.llvm.org/D32619





More information about the llvm-commits mailing list