[PATCH] D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 16:28:15 PDT 2017


tstellar added a comment.

In https://reviews.llvm.org/D32595#740222, @chapuni wrote:

> Let me know steps for testing that you suppose.
>  I guess;
>
> - Use installed version of lit via virtualenv.


Not necessarily via virtualenv, either by installing the lit pypi package or using a distro package: https://admin.fedoraproject.org/pkgdb/package/rpms/python-lit/

> - Use out-of-tree version of gtest.

I don't really have a plan for gtest, but this already doesn't work for out of tree builds (unless you have the source tree on your system, but I don't think we should be relying on this).

> - Use another build tree to use FileCheck &c.

These could come from a build tree or could be installed on this system.

> I know the clause CLANG_BUILT_STANDALONE would be made simpler if we could abandon testing in standalone build.




https://reviews.llvm.org/D32595





More information about the llvm-commits mailing list