[PATCH] D32140: Global code motion of congruent computations
Aditya Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 27 11:43:06 PDT 2017
hiraditya added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:140
static cl::opt<bool> EnableGVNHoist(
- "enable-gvn-hoist", cl::init(false), cl::Hidden,
+ "enable-gvn-hoist", cl::init(true), cl::Hidden,
cl::desc("Enable the GVN hoisting pass"));
----------------
mehdi_amini wrote:
> Is it intended to be part of this patch?
No, I'll remove this.
================
Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:482
+ if(EnableGVNHoist)
+ MPM.add(createGVNHoistPass());
+
----------------
mehdi_amini wrote:
> Can you clarify why is it inserted here? It seems like a strange place to me
I'll remove this as well, this was for my testing.
https://reviews.llvm.org/D32140
More information about the llvm-commits
mailing list