[PATCH] D32511: [AArch64] Add ARMv8.2-A FP16 vector intrinsics

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 09:21:16 PDT 2017


SjoerdMeijer added a comment.

Hi Abderrazek,
This looks very sensible to me. But I will go over it again just to see if we haven't missed anything (it's a big patch). Not sure though how the added f32 intrinsic tests help with the review, but maybe I am missing something...
Cheers,
Sjoerd.



================
Comment at: clang/include/clang/Basic/arm_neon.td:1673
+	// Comparison
+	def CMEQH    : SInst<"vceqz", "ud", "hQh">;
+	def CMGEH    : SInst<"vcgez", "ud", "hQh">;
----------------
Nit pick: use spaces for indentation instead of tabs.


https://reviews.llvm.org/D32511





More information about the llvm-commits mailing list