[PATCH] D32072: [AArch64] ILP32 Backend Relocation Support

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 01:21:49 PDT 2017


peter.smith added a comment.

New changes look ok, just from looking at the diff between the two patches I can see:
That there aren't any new tests for R_AARCH64_P32_TLSLD_LDST128_DTPREL_LO12 and R_AARCH64_P32_TLSLD_LDST128_LO12_NC forms (there is a comment) and I think that these are implemented as there is an earlier case in a different file that uses them. Have I got that one wrong?

That aside, and I'm sure you can remove the superfluous "debug.h" header prior to commit, unless there are any objections from anyone else I'd be happy to approve.


https://reviews.llvm.org/D32072





More information about the llvm-commits mailing list