[llvm] r300963 - typo

Clement Courbet via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 00:44:07 PDT 2017


Hi James, sorry for missing your email. Yes, that was a mistake, as
indicated in https://reviews.llvm.org/D32002. I forgot to rebase before
submitting. Sorry about that !

On Fri, Apr 21, 2017 at 11:39 AM, James Molloy <james at jamesmolloy.co.uk>
wrote:

> Hi Clement,
>
> Traditionally we prefer more descriptive log messages if possible. The set
> of 6 patches you've just submitted had terse log messages and look like
> they should have been squashed client-side. Was this a mistake on your
> part? If not, a more descriptive and less terse log message would be
> appreciated.
>
> James
>
> On Fri, 21 Apr 2017 at 10:34 Clement Courbet via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: courbet
>> Date: Fri Apr 21 04:21:05 2017
>> New Revision: 300963
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=300963&view=rev
>> Log:
>> typo
>>
>> Modified:
>>     llvm/trunk/lib/Target/X86/X86.td
>>
>> Modified: llvm/trunk/lib/Target/X86/X86.td
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/
>> X86/X86.td?rev=300963&r1=300962&r2=300963&view=diff
>> ============================================================
>> ==================
>> --- llvm/trunk/lib/Target/X86/X86.td (original)
>> +++ llvm/trunk/lib/Target/X86/X86.td Fri Apr 21 04:21:05 2017
>> @@ -275,7 +275,7 @@ def FeatureFastSHLDRotate
>>
>>  // Ivy Bridge and newer processors have enhanced REP MOVSB and STOSB (aka
>>  // "string operations"). See "REP String Enhancement" in the Intel
>> Software
>> -// Development Manual. This feature essentially meanis that REP MOVSB
>> will copy
>> +// Development Manual. This feature essentially means that REP MOVSB
>> will copy
>>  // using the largest available size instead of copying bytes one by one,
>> making
>>  // it at least as fast as REPMOVS{W,D,Q}.
>>  def FeatureERMSB
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170427/e3e22582/attachment.html>


More information about the llvm-commits mailing list