[PATCH] D32578: CMake: Set LLVM_MAIN_INCLUDE_DIR to LLVM_INCLUDE_DIR

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 23:19:17 PDT 2017


chapuni added a comment.

The changes themselves look good.
But I don't understand your issue. Did you happen to any cases that llvm-config or --includedir prevents something?

I think we may get rid of llvm-config there in near future. Instead, we should let CMake find LLVM as a package.

Possible steps;

1. Use llvm-config just to inform --cmakedir.
2. Add an option to use find_package(LLVM).
3. Nuke  llvm-config stuff. (Then, we might miss consistency of llvm-config...)


https://reviews.llvm.org/D32578





More information about the llvm-commits mailing list