[PATCH] D29609: [dsymutil] Follow dependencies during ODR uniquing

[Frederic Riss via Phabricator via llvm-commits]

friss added a comment.

@compnerd I have a technical objection above. I don't like the fact that it walks an unbounded number of new DIEs. Also, I really can't wrap my head around the logic that is being added, even after spending quite some time looking at it. I provided a prototype patch to Alexander that implements an approach that I like better (it still allows uniquing of typdefs). I looked at it again some nights ago, and the patch I provided is trivially extended to handle the new testcase. I'd much rather have work invested in an approach that still allows uniquing unless there are strong arguments against it.


Repository:
  rL LLVM

https://reviews.llvm.org/D29609