[lld] r301513 - Remove needless type conversions.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 21:01:15 PDT 2017


Author: ruiu
Date: Wed Apr 26 23:01:14 2017
New Revision: 301513

URL: http://llvm.org/viewvc/llvm-project?rev=301513&view=rev
Log:
Remove needless type conversions.

Modified:
    lld/trunk/ELF/InputFiles.cpp
    lld/trunk/ELF/Writer.cpp

Modified: lld/trunk/ELF/InputFiles.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=301513&r1=301512&r2=301513&view=diff
==============================================================================
--- lld/trunk/ELF/InputFiles.cpp (original)
+++ lld/trunk/ELF/InputFiles.cpp Wed Apr 26 23:01:14 2017
@@ -748,7 +748,7 @@ template <class ELFT> void SharedFile<EL
     // with explicit versions.
     if (V) {
       StringRef VerName = this->StringTable.data() + V->getAux()->vda_name;
-      Name = Saver.save(Twine(Name) + "@" + VerName);
+      Name = Saver.save(Name + "@" + VerName);
       elf::Symtab<ELFT>::X->addShared(this, Name, Sym, V);
     }
   }
@@ -891,9 +891,9 @@ template <class ELFT> void BinaryFile::p
   std::transform(Filename.begin(), Filename.end(), Filename.begin(),
                  [](char C) { return isalnum(C) ? C : '_'; });
   Filename = "_binary_" + Filename;
-  StringRef StartName = Saver.save(Twine(Filename) + "_start");
-  StringRef EndName = Saver.save(Twine(Filename) + "_end");
-  StringRef SizeName = Saver.save(Twine(Filename) + "_size");
+  StringRef StartName = Saver.save(Filename + "_start");
+  StringRef EndName = Saver.save(Filename + "_end");
+  StringRef SizeName = Saver.save(Filename + "_size");
 
   auto *Section =
       make<InputSection>(SHF_ALLOC | SHF_WRITE, SHT_PROGBITS, 8, Data, ".data");

Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=301513&r1=301512&r2=301513&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Wed Apr 26 23:01:14 2017
@@ -101,7 +101,7 @@ StringRef elf::getOutputSectionName(Stri
     for (StringRef V : {".rel.", ".rela."}) {
       if (Name.startswith(V)) {
         StringRef Inner = getOutputSectionName(Name.substr(V.size() - 1));
-        return Saver.save(Twine(V.drop_back()) + Inner);
+        return Saver.save(V.drop_back() + Inner);
       }
     }
   }
@@ -123,7 +123,7 @@ StringRef elf::getOutputSectionName(Stri
   // ".zdebug_" is a prefix for ZLIB-compressed sections.
   // Because we decompressed input sections, we want to remove 'z'.
   if (Name.startswith(".zdebug_"))
-    return Saver.save(Twine(".") + Name.substr(2));
+    return Saver.save("." + Name.substr(2));
   return Name;
 }
 




More information about the llvm-commits mailing list