[PATCH] D32509: Replace HashString algorithm with xxHash64

[Scott Smith via Phabricator via llvm-commits]

scott.smith added a comment.

In https://reviews.llvm.org/D32509#738971, @vsk wrote:

> Is it necessary to have a mac to run the mach-o tests? At any rate, changing the 'CHECK'/'DCHECK' lines to 'CHECK-DAG'/'DCHECK-DAG' should do the trick.


AFAIK the test only failed on the mac buildbot.  I'm of two minds on CHECK vs CHECK-DAG; it makes the test immune to hash order issues, but in some cases I believe it can make the test too permissive, since in the end it just makes sure the lines are present, not that they are grouped together in any meaningful way.


Repository:
  rL LLVM

https://reviews.llvm.org/D32509