[PATCH] D32552: [LibCallsShrinkWrap] Teach the pass how to preserve the dominator

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 13:32:11 PDT 2017


davide added a comment.

In https://reviews.llvm.org/D32552#738580, @efriedma wrote:

> Could you preserve the DT without requiring it?  Not that it matters much for performance, but it would more clear why this pass is requesting the domtree.


I'm not very familiar with the old pass manager infrastructure (I got involved only in new pass manager'y stuffs) and I don't want to cause troubles.
To double check, I just need to remove the `addRequired()` call/INITIALIZE_DEPENDENCY from the pass right? If so, I'll do another round of testing then commit.


https://reviews.llvm.org/D32552





More information about the llvm-commits mailing list