[PATCH] D32555: [SelectionDAG] Use various APInt methods to reduce temporary APInt creation

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:655
-    if ((NewMask & ~KnownOne & KnownZero2) == (~KnownOne & NewMask))
-      return TLO.CombineTo(Op, Op.getOperand(1));
-    // If all of the potentially set bits on one side are known to be set on
----------------
Just a note on this. If you go through the boolean algebra you'll figure out that the lines that were deleted here are equivalent to the earlier two lines.


https://reviews.llvm.org/D32555