[PATCH] D32509: Replace HashString algorithm with xxHash64

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/ADT/StringExtras.h:126
+/// Just fall back on xxHash64.  Yes we drop the high bits on platforms where
+/// unsigned == 4 bytes (which includes amd64), but xxHash64 already has good
+/// avalanching, so we wouldn't gain much if anything.
----------------
For consistency: x86_64?


================
Comment at: test/DebugInfo/X86/gnu-public-names.ll:218
+; CHECK-NEXT:  [[ANON_INNER]] EXTERNAL TYPE "(anonymous namespace)::inner"
+; CHECK-NEXT:  EXTERNAL FUNCTION "f3"
 ; GCC Doesn't put local statics in pubnames, but it seems not unreasonable and
----------------
vsk wrote:
> I'm not familiar with this test, but it's a bit concerning that more checks get added than removed. @aprantl, what are your thoughts on going forward with the test updates vs. making the output of llvm-dwarfdump not depend on the string hash function?
DWARFDebugPubTable::dump() iterates over the elements of an llvm::Set. We should have separate change first that sorts the set.


Repository:
  rL LLVM

https://reviews.llvm.org/D32509