[PATCH] D32530: [SVE] Scalable Vector IR Type

[Renato Golin via Phabricator via llvm-commits]

rengolin added reviewers: echristo, chandlerc, hfinkel.
rengolin added a comment.

Hi Graham, thanks for this work.

I think you have addressed all points in the previous review and I'm happy with the patch. It's very concise and simple.

We should let it simmer for a while to make sure no one else has any comment, as this is a core change in IR, and we should get as much eyes on it as possible.

I'm adding a few more people as reviewers and I hope the CC'd people can also have a look.

cheers,
--renato



================
Comment at: lib/IR/Type.cpp:623
+VectorType::VectorType(Type *ElType, ElementCount EC)
+  : SequentialType(VectorTyID, ElType, EC.Min) { Scalable = EC.Scalable; }
 
----------------
why not:

    : SequentialType(VectorTyID, ElType, EC.Min), Scalable(EC.Scalable) { }


https://reviews.llvm.org/D32530