[PATCH] D32355: [ELF] - Remove dead TLS relocations relative code for MIPS and ARM

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 02:48:52 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D32355#733674, @peter.smith wrote:

> Perhaps the names of those functions are a bit general, for example should isTlsLocalDynamicRel() be isRelaxableTlsDynamicRel()?


I would keep the names. It seems that isRelaxableTlsDynamicRel is too generic probably. 
TLS optimization spec defines explicitly the transitions between different models, 
for example general dynamic model can be relaxed to initial exes or local exec, local dynamic to local exec, initial exec to local exec.
And our current code currently proccesses these models in a pretty obvious way using the current names.

Rui, are you ok with landing cleanup introduced in this patch ?


https://reviews.llvm.org/D32355





More information about the llvm-commits mailing list