[PATCH] D32173: [ELF] - Assign absolute values in linkerscript correctly #1.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D32173#736989, @ruiu wrote:

> Since this patch doesn't handle the issue in general but just fixes one specific error, I'm inclined to just not to crash when the linker sees this pattern.


Sometimes I think its better to crash than produce broken output silently. For this case it would be much harder to find what is wrong with linux kernel if LLD would not crash.
I think it does not make much sense fix crash and keep producing wrong symbol address silently. I would suggest at least to error out in addition.

But what about solution used in https://reviews.llvm.org/D32174 ? I just rebased it and it is free from cycles problems you mentioned and looks solves issue in general.


https://reviews.llvm.org/D32173