[PATCH] D32281: [ARM] ACLE Chapter 9 intrinsics

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMInstrInfo.td:5736
+          (SMLAWB GPR:$a, GPR:$b, GPR:$acc)>;
+def : Pat<(int_arm_smlawt GPR:$a, GPR:$b, GPR:$acc),
+          (SMLAWT GPR:$a, GPR:$b, GPR:$acc)>;
----------------
efriedma wrote:
> ARMV5TEPat?  Same in other places; using plain "Pat" is a bad idea because we can end up with the wrong instruction in Thumb mode (and your tests wouldn't catch this because you don't check the encoding).
ah yes, thanks!


https://reviews.llvm.org/D32281