[PATCH] D21723: [RFC] Enhance synchscope representation

[Anastasia Stulova via Phabricator via llvm-commits]

Anastasia added inline comments.


================
Comment at: lib/IR/AsmWriter.cpp:2216
+  default:
+    llvm_unreachable("Invalid target syncscope");
+  }
----------------
Perhaps, I am missing something... I thought the original plan was to have a generic `syncscope(num)` for the targets to be able to interpret `num` is a specific way by different backends. Now, for outside of the main tree implementation it seems we will be forcing to extend the enum and thus maintaining the downstream changes. Would it be possible to allow arbitry numbers too without known meaning next to the known/identifiable scopes? I guess they could just be printed as integers similarly to the addrspace attribute in IR... 


https://reviews.llvm.org/D21723