[PATCH] D32516: [sampleprof] Drop test dependency on the string hash func (NFC)

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 17:45:07 PDT 2017


vsk created this revision.

The SampleProfWriter emits function information in an order determined
by the string hash function. The situation is a bit brittle, because
changing the hash function can break the tests.

Instead of sorting the function samples to get a relaible ordering (that
might be too expensive), make the tests not depend on a particular
ordering of function samples.


https://reviews.llvm.org/D32516

Files:
  test/tools/llvm-profdata/overflow-sample.test
  test/tools/llvm-profdata/sample-profile-basic.test
  test/tools/llvm-profdata/weight-sample.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32516.96660.patch
Type: text/x-patch
Size: 10051 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170426/e572665c/attachment.bin>


More information about the llvm-commits mailing list