[PATCH] D32509: Replace HashString algorithm with xxHash64

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks for working on this! In the future, please set llvm-commits as a subscriber on differential revisions, not as a reviewer. Also, please upload patches with context (e.g "git diff -U1000").

IMO, tests which break when the string hash function is changed are suspicious. Why is a dependence on a specific hash function being tested? It might make sense to fix the tests in prep commits (ideally no test updates would be needed with this patch). I'll look into fixing the llvm-{cov,profdata} issues.



================
Comment at: include/llvm/ADT/StringExtras.h:130
+{
+  return xxHash64(Str, Result);
 }
----------------
Would xxh32 run significantly faster/slower than xxh64?


Repository:
  rL LLVM

https://reviews.llvm.org/D32509