[PATCH] D32267: Add a new WeakVH value handle; NFC

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/llvm/IR/ValueHandle.h:37-38
   /// fully general Callback version does have a vtable.
-  enum HandleBaseKind { Assert, Callback, Tracking, WeakTracking };
+  enum HandleBaseKind { Assert, Callback, Weak, Tracking, WeakTracking };
 
   ValueHandleBase(const ValueHandleBase &RHS)
----------------
sorting?


================
Comment at: include/llvm/IR/ValueHandle.h:129-130
 
+/// \brief A nullable Value handle that is nullable.
+///
+/// This is a value handle that points to a value, and nulls itself
----------------
Maybe `a nullable value handle` is enough?


https://reviews.llvm.org/D32267